gobot
gobot copied to clipboard
added new adaptor to allow for multiple joysticks
current adapter hard coded loading only the first joystick. added a new adapter that would allow for arbitrary joysticks based on id
Hello @Brownie79 first of all, thanks for your contribution.
I changed the branch on the PR to dev
as documented here: https://github.com/hybridgroup/gobot/blob/master/CONTRIBUTING.md#general-guidelines
We also just merged a fix for the Travis build problems, unrelated to your PR.
Could you please rebase your PR against the dev branch and push again?
Thank you!
Meanwhile there is another PR available for the same feature: #732 . It looks quite similar, but has the following advantages IMO:
- compute the err-code of "sdl.Init()"
- use the name instead of ID is more user friendly
- add just the first device if there are more than once (with the same name)
Because the "usage of name is an advantage" is just my feeling, I referenced the existing issue #564 to collect some requirements and add both PR's as reference.
Set this PR back to draft as reference of a new/improved implementation.
Hey @gen2thomas
I am adding stadia gamepad, so let me know if i can help with this PR etc.
accidentally closed - now reopen