Hyang-Ah Hana Kim

Results 384 comments of Hyang-Ah Hana Kim

> Should users be able to specify what signal to send with the TerminateRequest (e.g. SIGTERM or SIGINT)? > Should this be opt-in so those users who don't have signal...

@tamayika Thanks for the report. Sorry that I didn't know users depend on this feature to use custom vet analysis. Currently gopls doesn't allow custom analysis. @stamblerre This affects the...

@tamayika thanks for understanding. Released v0.21.1 and that will still accept the flag. We hope to address your use case in #1109, separate from this issue.

Discussion around [`textDocument/getDiagnostics`](https://github.com/microsoft/language-server-protocol/issues/737) looks relevant. The proposed API for pullDiagnostics is currently available in [vscode language client](https://github.com/microsoft/vscode-languageserver-node/blob/52986464725dda4fb721f6d2684c1b0f8c18b80c/client/src/common/proposed.diagnostic.ts#L97)

@alok87 what problem were you trying to solve? This issue was about whether to allow users to control "when" gopls runs diagnostics (realtime vs on-save vs never). While we are...

@belak For mono-repo, [build.directoryFIlters](https://github.com/golang/vscode-go/wiki/settings#builddirectoryfilters) can be used to make gopls scale. (not only diagnostics, but more), and if the mono-repo consists of multiple go modules, gopls won't diagnose modules in...

Looks like this is the old way of generating interface stub (that's based on `impl` tool, not `gopls`) If you generate the stub using the gopls's code action (see below),...

My guess is a race while restarting the language server -- From the restart history and the issue timestamp, it looks like the language server restarted as as a result...

@jamalc Even `go list` is slow, not completing within 20s isn't normal. I guess a bug in the test or a race condition. Do you have time to look into...

Thanks for the report. If it's reproducible, can you please capture the log and share it for triaging? https://github.com/golang/vscode-go/wiki/troubleshooting#collect-extension-logs