celeste icon indicating copy to clipboard operation
celeste copied to clipboard

Handle some GDrive errors directly from UI

Open dzek69 opened this issue 2 years ago • 5 comments

This is probably blocked by #59 - it requires Celeste to have any rclone/servers settings in the UI first, but I report it while I remember

I have a file that Google considers "abusive", so syncing ends with the error: image

Error message suggests to add a flag to rclone to confirm I want abusive files to be downloaded on my computer. While this is currently impossible from UI - after it will become possible this exact error on click could ask user if they want this config setting to be automatically changed for them.

dzek69 avatar Feb 26 '23 12:02 dzek69

Do you think it'd make sense to always just leave that flag enabled? Celeste usually just syncs personal files, so users would probably always consider those kinds of files safe. What do you think?

hwittenborn avatar Feb 27 '23 14:02 hwittenborn

I don't think it should be enabled by default, because if I had some shared folder (I shared some folder with write access or just pinned somebody's folder into my drive) other people could push a virus to it (even by accident, because their PC got infected) that I may not want on my PC.

That's a risk that should be prevented by default and only clear statement that I know the risks should enable that.

Ideally it would ask me once for each new file with the issue, but I guess this is something that only rclone can implement? I don't really know what exactly Celeste is responsible for and what is a rclone responsibility, sorry.

dzek69 avatar Feb 27 '23 14:02 dzek69

I don't think it should be enabled by default, because if I had some shared folder (I shared some folder with write access or just pinned somebody's folder into my drive) other people could push a virus to it (even by accident, because their PC got infected) that I may not want on my PC.

I didn't think about that, that's fair enough logic for me.

Ideally it would ask me once for each new file with the issue, but I guess this is something that only rclone can implement?

Celeste should be able to implement it, Celeste has a database file and I can just store what files have accepted the warning in there and then pass the needed flags to rclone. It would probably be good to add options for one-time accepts and accepts that work forever, right?

hwittenborn avatar Feb 27 '23 14:02 hwittenborn

Yeah, sounds great!

dzek69 avatar Feb 27 '23 15:02 dzek69

I'm back, been busy the past few days. Sounds good though, I'll get this implemented soon! :)

hwittenborn avatar Mar 03 '23 15:03 hwittenborn