langchainjs icon indicating copy to clipboard operation
langchainjs copied to clipboard

DOC: <Issue related to /docs/integrations/callbacks/datadog_tracer/>

Open sabrenner opened this issue 1 year ago • 7 comments

Checklist

  • [X] I added a very descriptive title to this issue.
  • [X] I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:

Datadog LLM Observability has recently released a Node.js SDK, and along with that are some upcoming changes to automatically instrument LangChain. It would make this LangChain community Datadog LLM Observability callback documentation obsolete: https://js.langchain.com/docs/integrations/callbacks/datadog_tracer.

Idea or request for content:

It'd be good for this page to point to the official Datadog documentation instead (similar to our Python SDK counterpart: https://python.langchain.com/docs/integrations/providers/datadog/) once the auto-instrumentation is released.

sabrenner avatar Nov 13 '24 14:11 sabrenner

Hi @bracesproul - any idea when this could request can be handled?

barieom avatar Dec 02 '24 22:12 barieom

@barieom we would love a community contribution for this!

bracesproul avatar Dec 02 '24 22:12 bracesproul

Hi @bracesproul, I'm happy to open a community PR for this effort (now that we have just released this support in our Datadog Node.js SDK)!

I'm working on making the content changes for the page, but I'm wondering if you had an opinion on where it should end up in the docs directory. Callbacks doesn't sound right to me, but I don't see another good place (in the Python docs, there is /docs/integrations/providers/datadog/, but I don't see a great equivalent in this repo under /docs/integrations, besides maybe platforms?).

Feel free to leave a suggestion for me here, but I'll end up opening the PR hopefully this week anyways and I can get feedback there directly as well 😄 thanks!

sabrenner avatar Jan 23 '25 17:01 sabrenner

The issue with deprecating the community callback is that the official package does not currently support ESM, which is likely a large percentage of the user base.

ianwoodfill avatar Feb 07 '25 00:02 ianwoodfill

@ianwoodfill this is a very fair point. we're looking to fix that compatibility soon. once we do, I can update here and revisit this to deprecate the community callback with new documentation.

sabrenner avatar Feb 11 '25 18:02 sabrenner

Much appreciated, @sabrenner. Looking forward to being able to use dd-trace directly.

ianwoodfill avatar Feb 11 '25 18:02 ianwoodfill

Hey folks, I wanna follow up here - we released ESM compatibility in [email protected], so we should be unblocked here for deprecating the community callback. I'll get back on writing a new doc for using Datadog LLM Observability with LangChain 😄

@bracesproul I want to bump my question here - where would you suggest placing this documentation (I sorta doubt it should live under Callbacks). Thanks in advance!

sabrenner avatar Mar 14 '25 17:03 sabrenner

I want to bump my question here - where would you suggest placing this documentation (I sorta doubt it should live under Callbacks). Thanks in advance!

@sabrenner thanks for getting back to us and sorry about the delay. We have moved our docs to a new place and would appreciate any form of contribution there. Thank you!

christian-bromann avatar Sep 12 '25 17:09 christian-bromann

@christian-bromann thank you! i'll open a new PR there shortly 😄

sabrenner avatar Sep 12 '25 19:09 sabrenner