Hielke Walinga

Results 33 comments of Hielke Walinga

Then I don't know exactly how quantulum works. I thought there was machine learning doing the matches, not exact matching? I also learned you will get random output. There is...

Yes, random output is bad. At least a warning should be thrown if picking a random option. Anyway, I made a PR.

Oh, I based of master instead of dev. Should I do this again? EDIT: I rebased.

OK, I created #164 for all my import sorting and there was a block not black formatted. I have moved the logic one layer up and also implemented it for...

Good suggestions. I applied them.

Hmmm.. There is no Mbar in units.json, only a mbar and a μbar. So, it won't work anyway, but at least the code for it is now in place.

Your test suite is a bit weird. Automatically loading a bunch of test cases is clever, but you are better off designing the tests yourself so that you can have...

OK, ping me when you updated the test suite, than I can see how I can learn from that to make tests for this PR.

The test suite still misses a simple single test like I would want to add as well. It still all obscure automated testing, now with subtests though. To repeat what...

Yes, but the problem of that approach is that those tests are not isolated. (1) I cannot run a single test that gives problems. (2) I have to run the...