Zecong Hu

I like `Dataset` as well. I think the terms people use to describe data-related modules are pretty messy, so as long as we're being consistent it's fine. Let me reiterate...

Sure. I'll get on it.

Oh, one problem with using `logging` would be that it's probably not possible to log download progress in this way, because `logging` does not support clear lines. Also, there's a...

Thank you for using Texar! Unfortunately we don't have current plans to add built-in support for copying mechanism. That said, given what's already in the library, it shouldn't be too...

@ZhitingHu This part of implementation is the same with texar-TF. In dataset processing methods only those from the `hparams` are used, I don't think `vocab.bos_token` and `vocab.eos_token` were used anywhere...

I can confirm that I'm no longer seeing this issue so far since I've upgraded to 2022.10. Thanks!

Update: Unfortunately, the issue still exists :( I'm now seeing the same exceptions as before.

The code above used HTML5 history API (`history.pushState`) but not History.js (`History.pushState`).

No worries! > Have you tried your changes (haven't looked too closely at them tho) and checked if our test suite still passes? 🤔 So the following is the patch...

Thanks for the suggestion! Could you describe your use case in more detail? Personally I don't really see the benefits of using `argtyped` if your arguments are dynamically created, as...