codedaily-v3 icon indicating copy to clipboard operation
codedaily-v3 copied to clipboard

Published 20 hours ago • verified publisher icon huytd

/www code cleanup

Open Cxarli opened this issue 7 years ago • 3 comments

The code in the /www folder is now a bit cleaner, by:

  • formatting, adding whitespace
  • taking care of edge cases
  • adding browser support

The colors from theme.scss are now in colors.scss, so that they can be changed easily later.

I recommend using tools such as eslint, jshint and sass-lint to keep your code clean. This commit also adds configuration files for them.

Happy hacktober!

Cxarli avatar Oct 07 '17 14:10 Cxarli

@C-Bouthoorn could you please check the conflict here please?

huytd avatar Oct 19 '17 17:10 huytd

@C-Bouthoorn would it make sense to have three separate commits (or even three PRs) for three bullet points mentioned accordingly in the PR description? IMHO, that makes PR reviewing easier and commit tree traversal in the future better.

qcam avatar Oct 20 '17 06:10 qcam

Yeah, could be. I just scanned through the code and applied changes everywhere, then made a commit and wrote the description afterwards. I didn't really think I would do multiple things

Cxarli avatar Oct 20 '17 21:10 Cxarli