Screenbox icon indicating copy to clipboard operation
Screenbox copied to clipboard

Published 20 hours ago • verified publisher icon huynhsontung

Problem with selecting the playback speed

Open vladkryv opened this issue 9 months ago • 0 comments

Describe the bug Of the speeds offered, only 1x and 2x work, selecting other speeds does not change anything. At the same time everything works with “Custom value”.

How To Reproduce Steps to reproduce the behavior:

  1. Open any video (I checked mp4)
  2. Click on 'Playback speed'
  3. Select 0.25/0.5/0.75/1.25/1.5/1.75 (any)
  4. See that the playback speed does not change

Expected behavior Change the playback speed when choosing any option.

Environment

  • OS: Windows 11
  • Device: Asus Laptop (Intel Core i7-9750H; Intel UHD Graphics 630; NVIDIA GeForce GTX 1650)
  • App Version: v0.12.6.0

Additional context Reproduce in Ukrainian and Russian interface language, in English there is no problem.

The problem is in this location - https://github.com/huynhsontung/Screenbox/blob/3adb05eefb3cabc71b29cdf65f4853d21324b9e5/Screenbox.Core/ViewModels/PlayerControlsViewModel.cs#L293

To solve the problem you can replace this line with if (!double.TryParse(speedText, CultureInfo.InvariantCulture, out double speed))

In other places where the double.TryParse is used, I think you should also add this parameter.

vladkryv avatar May 12 '24 12:05 vladkryv