Huy Do
Huy Do
@pytorchbot merge -f 'The failure is surely unrelated'
@pytorchbot revert -m 'Sorry for reverting your change but it is failing ROCm jobs in trunk https://hud.pytorch.org/pytorch/pytorch/commit/ee4cafa098ede2d9546016223cbc1a522ea3630a' -c nosignal I will add `ciflow/rocm` to run the jobs on your PR.
This issue has been partially resolved now that we have a hook to chown everything back to the correct runner user.
Checking with @atalman on this, and we have no plan to fix the run by root part atm. But, the files are now chowned to the correct user before and...
AI: Cancelled signals should be surface in clear way 1) if the job is cancel by user, we should tell that the merge is cancel 2) if the job is...
The first point is correct, when the jobs are cancelled by the user, we want them to show up as failures and block merge. However, if the jobs are canceled...
> IIRC if we just show cancelled jobs as cancelled, when the new job kicks off we'd automatically show the status of of the now-running job, right? Yeah, that's what...
AI: It's better to be able to keep the test as XFAIL if possible or a special decorator like `skipifFlaky`
This has been fixed by https://github.com/pytorch/test-infra/pull/5151, so I will close this.