Steven Huss-Lederman
Steven Huss-Lederman
Noting that this issue is still open and not real progress has been made.
Let me clarify that in some places we do Window.alert() that is not React friendly. These should be switched to the new methods in src/client/app/utils/notifications.ts that use a React way....
After PR #1113, the only ones left are Window.confirm. It would be good to find a confirmation dialog that is compatible with the toast notifications that are used.
@ShubhamPatilsd Is this still active? @diana-galeana are you working on this?
Issue #1303 discusses client-side conversions. If time varying conversions are successful then that should not be done.
@AchsahJojo I don't think you have done a test case before so it is okay to do one.
@AchsahJojo Oops. I just looked at the code base and this test has already been done. Not sure why the issue was left open. You should find a different test...
This is complete so closing.
I tested this some more. If you wait at least several seconds after saving the unit after the rate change then it all works as desired. However, if you quickly...
I looked into this some. First, I'm setting the label as low-priority since this seems to only happen if you delete a map while using it. This means an admin...