Steven Huss-Lederman

Results 240 comments of Steven Huss-Lederman

> The isValidGPSInput in src/server/services/csvPipeline/uploadMeters.js is very similar to the modified one you changed in src/client/app/utils/calibration.ts. It was not your doing that there are two version but I think it...

I addressed all the comments.

After talking with @mrathgeber and thinking about this, I have decided that deleting a conversion involving any unit that is compatible with any used meter unit is problematic. This same...

For the record, this is the ideas of doing all the checks. It may need some modification and more details but should generally be okay. The parts of issues with...

Note the failed tests are not a result of this PR but a general issue that is yet to be resolved.

@aduques I assigned you this issue since I think you wanted to try it. Let me know if you don't want this.

@aduques Thanks for figuring this out and updating us on what is going on. Let me know if you need anything and I look forward to adding this improvement to...

I think it would be nice to make all the modals warn about unsaved changes so doing these would be good. Maybe you meant edit user not edit unit?

> Hey @huss! Thanks for the feedback, currently our classes just started but I do want to continue with this, I will try fixing these iss @rianhassett Thanks for letting...

> > Hey @huss! Thanks for the feedback, currently our classes just started but I do want to continue with this, I will try fixing these iss > > @rianhassett...