hupfdule

It is still functional. There was no rollback. It seems that installation just failed, but didn’t break anything. So I will just stay on 3.9.2. Thanks for the hints.

I added a fourth commit that caches the configured keys to not have to fetch them from PROGMEM twice. I’ve got the idea from the Qukeys plugin and basically copied...

> One thing I'm wondering is whether this belongs in AutoShift or ought to be a generalized LongPress plugin on its own, since it's not really auto-shifting here. I thought...

Hmm, I just force pushed the commits to fix formatting problems and now the already executed checks are gone. Should I refrain from force-pushing to this PR?

The code style check currently complains about this line in the example AutoShift.ino: ``` AUTOSHIFT( kaleidoscope::plugin::LongPress(Key_Slash, Key_Backslash), ) ``` and wants it in that form: ``` AUTOSHIFT( kaleidoscope::plugin::LongPress(Key_Slash, Key_Backslash), )...

OK, I have changed it accordingly.

> I've been going through this PR today, and I have a few observations. Great! Many thanks for reviewing it. > First and foremost, the configuration itself: it's done in...

Hello and thanks for your answer! > I think we do want this functionality. I also think we want it with a plugin name like LongPress rather than AutoShift, so...

One question regarding the configuration of the plugin (Not only, but also in respect of having it configurable via Chrysalis). At the moment the user needs to specify the (logical)...

I have created [a new PR for the LongPress plugin](https://github.com/keyboardio/Kaleidoscope/pull/1423). It was easier for me to separate it into a different branch and we can easier compare it to this...