Huo Yaoyuan
Huo Yaoyuan
I'm a bit confused with this change: There's no documentation about diagnostic ids and corresponding rules now. Even if there is one, splitting rule preference and severity into two places...
It looks like InspectCode version is too low for C# 11, which is necessary.
OK it's a well known pitfall - do not compare span and string with `==`.
Should I update InspectCode in this PR? The update to BenchmarkDotNet is just package version, should it be included?
Glad to see .NET 8 being adopted. The parsing can be simplified more with .NET 8 and C# 12 feature. I'll revisit this, probably this month.
Note that this is a extremely common type of localization error in many Microsoft products: incorrect language order processing. The `true` and `Task` in the localized documentation has been swapped.
The productization of this repo is currently designed at dotnet/runtime repo (https://github.com/dotnet/runtime/issues/84177).
> Are you talking about `Microsoft.Extensions.Configuration.CommandLine` (which is a completely different library)? No. I'm even unaware of such a library. The linked issue (https://github.com/dotnet/runtime/issues/84177) is discussing API in `System.CommandLine` namespace....
> if I target C# 11 or lower, I get a warning that this code will introduce a breaking change in C# 12 as described in the specification. If I...
If extension methods are allow to shadow instance methods in some way, can we use this feature to set a preference of `GetAwaiter` related methods to avoid `ConfigureAwait` at each...