Huon Wilson

Results 245 comments of Huon Wilson

FYI @grihabor, I'm going to be on leave for 2 weeks from tomorrow. Please feel free to work through my remaining comments and/or solicit more reviews on #development on slack....

Thanks for waiting. I think this is fine to land as experimental (as it is) pending @kaos's change. I'd like to see some more thinking on https://github.com/pantsbuild/pants/pull/20360#discussion_r1439897543, because I don't...

Thanks for waiting. I tried running these tests locally, without `zstd` available, and observed that tests fail: ``` pants.core.util_rules.system_binaries.BinaryNotFoundError: Cannot find `zstd` on `['/bin', '/opt/homebrew/bin', '/usr/bin', '/usr/local/bin']`. Please ensure that...

(Just being explicit: approval conditional on the copy-editing and answering that question, in case that wasn't clear. 😄 )

Hm, I think there's something deeper going on here: Pants attempts to set that property itself, but that is seemingly not working: https://github.com/pantsbuild/pants/blob/e4aaf382459c4362450440b8c20518af446f686c/src/python/pants/backend/python/goals/coverage_py.py#L276-L298 As such, reopening.

https://github.com/pantsbuild/pants/issues/15062 is related for the built-in PEX question. In working on #20237, I wonder if we could potentially have a more general field like `extra_pex_args=["--no-compress"]` that'd give us a "workaround"...

In addition to the `--no-compress` option, `--no-pre-install-wheels` from https://github.com/pantsbuild/pex/releases/tag/v2.1.154 is likely also interesting for the root cause of this feature request (and would also be possible to use with arbitrary-arg...

I've added `extra_build_args` in #20737 as an escape hatch, which allows a stop gap here... but the thinking developing in the discussion on that thread is that Pants-levels fields are...

I think we may want to be careful about failing for "known" unsupported platforms, because they may not be unsupported in all circumstances, and blocking users spuriously is frustrating (of...