Huon Wilson comments

Results 245 comments of


                                            Huon Wilson

Update builtin docformatter to 1.7.5

Docformatter isn't idempotent, i.e. there's an infinite loop that duplicates some lines, so this can never pass as is. https://github.com/PyCQA/docformatter/issues/263

Add script to identify backends not part of the pants distribution.

Nice! Is this something we can execute as a Pants test, so it gets run in CI automatically? One idea: a codegen target that exposes the output of `peek`, that...

Add script to identify backends not part of the pants distribution.

My idea of a peek goal target is potentially too hard in the immediate term (although might be nice for users too)... an alternative that lets us start seeing the...

Building internal PEXes for built-in tools with `[pex].emit_warnings` shows warnings that seem useless

Heya @cburroughs, thanks for exposing the warnings. Do you have thoughts on this consequence of it?

Building internal PEXes for built-in tools with `[pex].emit_warnings` shows warnings that seem useless

Removing this from the 2.20.x milestone, since we landed #20593 as a stop-gap to reduce severity in 2.20.0

Building internal PEXes for built-in tools with `[pex].emit_warnings` shows warnings that seem useless

Ah, yes, thanks, I think this is now fully covered by #20586. The stopgap from #20590 is still around in 2.21 (and 2.22 etc.): https://github.com/pantsbuild/pants/blob/2.21.x/src/python/pants/backend/python/util_rules/pex_environment.py#L85

Building internal PEXes for built-in tools with `[pex].emit_warnings` shows warnings that seem useless

Oh, wait, hm, no, #20586 covers tests related to Pants' dependencies. The warnings are there for built-in tools. I'll reframe this one.

Building internal PEXes for built-in tools with `[pex].emit_warnings` shows warnings that seem useless

And indeed, not blocking for 2.21 👍

javascript: add node v20 to default known versions

Heya @tobni, the test failures here looks like something you might have insight into. What do you think?

use_buildx on macos results in failure to package/build the image.

Thanks for taking the time to file an issue, and sorry for the trouble. I tried setting `use_buildx = true` in a repo I have that uses `docker_image` targets and...