Huon Wilson comments

Results 245 comments of


                                            Huon Wilson

"big" docker inputs slows pants to a crawl; hangs/freezes(?) UI

Idle thought based on the UI dots hanging: I wonder if part of the problem here is some blocking code running within the async/await executor, i.e. if the UI is...

404 page not rendered when `routeBasePath` is `"/"`, and no version uses that path

There's some bits of code that seem to have the intention of showing the `` 404 component when there's no route match... but apparently not triggering? - fallback handling: https://github.com/facebook/docusaurus/blob/ca09f238f3d809641614309cd8118a4e42475c1b/packages/docusaurus/src/client/exports/ComponentCreator.tsx#L28-L45...

404 page not rendered when `routeBasePath` is `"/"`, and no version uses that path

Ah, right, okay, so with `routeBasePath` == `/` as we configured, the docs plugin catch-all route is `/*` and presumably is in the route list before that final catch-all, and...

Add support for buildifier style in BUILD files, or support running an auto-format binary after `pants tailor`

I agree with your point that this could be better: pants is writing new data to file that it (a) knows how to reformat, and (b) knows should be reformatted....

BUILD couldn't be created in a directory which contains a directory called build

Ah, overlapping (case-insensitive) filenames is unfortunate. We could definitely improve the diagnostics here. The default `build_pattern` option (https://www.pantsbuild.org/2.20/reference/global-options#build_patterns) includes any `BUILD.*` files, so a workaround would be to use file...

`experimental_shell_command` in a docker environment that timeouts doesn't kill process

Potentially a wild idea: instead of starting the container with `/bin/sh` as the entry point, start it with a watchdog server process that can: - be used to kill tasks...

Bundle OpenAPI files as a single resource

Sorry for letting this one sit for so long. When you have a chance, please merge main (or rebase onto it) and add some release notes to docs/notes/2.22.x.md (maybe in...

Ambiguous pex_binary entry_point fields get ambiguous dep inference warnings that cannot be disambiguated in 2.20

Heya @lilatomic I think you might've added this new warning (thanks for improving diagnostics!). Could you describe the background for #20390? Did you find circumstances where the existing warning didn't...

Docker environment leaves old containers running forever on error

This may (or may not) be related to to #18209 or #18210, which are also vaguely related to environments and clean-up.

Use Wildcard When jvm_exclude Artifact is None

Awesome! I'll let @alonsodomin shepherd this though for real, but from a quick skim, could we add a test for this, to be sure it continues to work in future?