Hunter Nield

Results 26 comments of Hunter Nield

I would imagine similar issues if there was no repo added and all tests were triggered from docker reg webhooks. Might be worth looking closer at k8s users and the...

Nice. I think my only initial comment is that rather than using `uuid` for user we use the same convention as [ABAC](http://kubernetes.io/docs/admin/authorization/) with `user`

Services. I'm not sure liveness/readiness probes make sense for jobs since they aren't long running

Updated with some info on ThirdPartyResources

My current understanding of ThirdPartyResources is that only the resource is stored in etcd. For the rest of associated data it should be stored outside of that (so I assume...

Ah yeah, I hadn't considered storing more than pipelines in there. One thing we might need to check is if TPR is enabled in GKE

How will users be managed in this API? Per-user pipelines (with different auth flows for different services). Can we use the K8s user (which would probably fit the TPR model)?

Would it make sense to use gRPC which seems to be the trend for newer K8s Go projects? (Helm, etcd)

> This would relate to the controllers too. I think it would be better for the API to have separate data structures for the pipelines, builds, and stages. The API...

> should pipelines be linked to users? eg. 2 users accessing the same repo can have separate pipelines? which means a repo can have several hooks pertaining to a pipeline?...