shadcn-svelte icon indicating copy to clipboard operation
shadcn-svelte copied to clipboard

Vertical orientation for tabs

Open martinjo opened this issue 10 months ago • 4 comments

Describe the feature

Tabs have a ”orientation” property that I was expecting to affect how the tabs orient themselves visually. It seems to have no or another effect. But having an orientation property that affects layout (horizontal/vertical) would be so nice.

Are there any plans for this or examples of how it could be achieved?

martinjo avatar Mar 27 '24 06:03 martinjo

The orientation is for accessibility purposes. We could possibly add an example for vertical tabs.

huntabyte avatar Mar 27 '24 14:03 huntabyte

I figured it had some function :). An example with vertical tabs would be great! 🙏

martinjo avatar Mar 27 '24 15:03 martinjo

What would the example need to be? Like just a piece of code or a with a selectable preview also?

BeGeos avatar Apr 09 '24 18:04 BeGeos

@huntabyte The name of the property `orientation' (The orientation of the tabs) is a bit misleading, it suggests that the tabs could be visually rendered horizontally or vertically. The documentation in the code of bits-ui is clear about this but I can imagine that people would be a little disappointed when finding out that it only applies to keyboard navigation...

What to do? Update bits-ui property name and docs or update the shadcn-svelte docs with a remark about the tabs properties? Or a third option: implement visually vertically rendered tabs?

oluijks avatar Jun 28 '24 06:06 oluijks