shadcn-svelte icon indicating copy to clipboard operation
shadcn-svelte copied to clipboard

bug: Lucide icons overlap the `Alert` component on Firefox

Open AdrianGonz97 opened this issue 1 year ago • 2 comments

ff

AdrianGonz97 avatar May 28 '23 01:05 AdrianGonz97

This is due to Firefox lacking support for the has() CSS selector. They are expected to have the feature implemented in the first 1/2 of this year (source), but I may still update the component to function without it for the time being.

huntabyte avatar May 28 '23 03:05 huntabyte

Is this something we feel we should accommodate Firefox for? The has selector is what makes this component so simple to use. I'd be open to it if there was an alternative way with comparable implementation.

huntabyte avatar Jun 03 '23 23:06 huntabyte

Is this something we feel we should accommodate Firefox for? The has selector is what makes this component so simple to use. I'd be open to it if there was an alternative way with comparable implementation.

I probably wouldn’t make a change here because of your reasoning. But, I found a package on npm which could solve that problem till Firefox gets support (didn’t test it yet). Maybe, if it works, add a note in the documentation that this could solve the problem with Firefox? And then just remove the note again when the update dropped.

https://www.npmjs.com/package/css-has-pseudo

Mxrk avatar Jun 10 '23 12:06 Mxrk

Closing as not implementing

huntabyte avatar Aug 19 '23 01:08 huntabyte