word-rnn-tensorflow icon indicating copy to clipboard operation
word-rnn-tensorflow copied to clipboard

Save directory checking?

Open hunkim opened this issue 9 years ago • 5 comments

Should we put the save directory under the data directory? Or at least, we need to check if the directory exists.

hunkim avatar Oct 16 '16 14:10 hunkim

Ckpt.model_checkpoint_path: indicates the location where the model is stored, does not need to provide the name of the model, because it will check the checkpoint file to see which one is the latest and what does it called.

In source code saver.py the method get_checkpoint_state will check that the file exists before opening it. so I think there is no need to put the save directory under the data directory. image

sunxiaobiu avatar Oct 30 '16 16:10 sunxiaobiu

So you want to put the results in the input data folder? Could you make a pull request?

hunkim avatar Oct 31 '16 06:10 hunkim

@sunxiaobiu Any thoughts?

hunkim avatar Nov 03 '16 07:11 hunkim

The result set for each training session is automatically saved in the save / model path, and is not overwritten as long as the new model name is not reassigned. So there is no need to put the save file under the data directory.

sunxiaobiu avatar Nov 04 '16 07:11 sunxiaobiu

If we have two input data directories and run training twice, I think it will overwrite, right? On Fri, 4 Nov 2016 at 3:43 PM, sunxiaobiu [email protected] wrote:

The result set for each training session is automatically saved in the save / model path, and is not overwritten as long as the new model name is not reassigned. So there is no need to put the save file under the data directory.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/hunkim/word-rnn-tensorflow/issues/18#issuecomment-258363472, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3DV-4bnC9HJPX6Vl6VxOWyzFdP7rc6ks5q6uITgaJpZM4KX_Vl .

hunkim avatar Nov 04 '16 08:11 hunkim