Henry Vu

Results 32 comments of Henry Vu

> Don't start the operator metrics server if tetragonOperator.prometheus.enabled = false @lambdanis not really get the point on this? should be a new flag that we can disable at here...

> > > Don't start the operator metrics server if tetragonOperator.prometheus.enabled = false > > > > > > @lambdanis not really get the point on this? should be a...

we have same issue - Cloud dns provider: Azure - external-dns args : traeafik-proxy - K8S platform: AKS - Ingress Controller: Treafik - IngressRoute: traefik.io/v1alpha1 seem that there 2 same...

build failed? maybe needed `pkg/model/notificationevent.pb.go` @minhquang4334

@Warashi seem a lot of duplicate code here for handle slackGroups, do you have any idea? @minhquang4334 @khanhtc1202 @Warashi

> I checked the behavior, and this PR worked as expected! Thank you! > > By the way, I have an idea about duplicated codes. How about defining the wrapper...

@ffjlabo @Warashi Thank you so much for your feedback @ffjlabo > I think there are two processes in the `GetApplicationNotificationMentions`. > > * get the value (type `*config.DeploymentNotification`) from the...

@ffjlabo @Warashi thank you for your feedback, updated to follow the idea on unify process to get Users and Groups for planner, scheduler, executor