Pilot icon indicating copy to clipboard operation
Pilot copied to clipboard

Per voice FX ?

Open giann opened this issue 6 years ago • 8 comments

Is it possible to have individual FX for each voice? Or to play a single note with an effect?

giann avatar May 29 '19 08:05 giann

Pilot is a bit too limited for this kind of gymnastic at the moment, I would need some help to get this in.

neauoire avatar May 29 '19 08:05 neauoire

I think it should be fairly simple. Just like you have a Tone.Envelope for each voice, you could have a FX parameter.

giann avatar May 29 '19 08:05 giann

Would you like to give it a shot and submit a PR? I'd totally merge that.

neauoire avatar May 29 '19 08:05 neauoire

I'll try

giann avatar May 29 '19 08:05 giann

You got this ✊

neauoire avatar May 29 '19 08:05 neauoire

What would be better? One FX slot for each voice and you can choose which effect you put there. Or all FX available for each voice and you set the amount for each of them like you do for master FX right now? I don't know how we could represent the latter in the UI without it being a little too much.

giann avatar May 29 '19 08:05 giann

I think one fx slot by voice is enough for now it'd be an addional column per voice:

0 0D00 8ISI WAH0F ----

giann avatar May 29 '19 08:05 giann

This wasn't so hard :) Love the fact that you didn't went for any fancy js framework: the codebase is small and really easy to understand as a consequence.

giann avatar May 29 '19 12:05 giann