hummingbot icon indicating copy to clipboard operation
hummingbot copied to clipboard
verified publisher icon hummingbot

Bounty: Clean up `gateway balance` command and add allowances

Open fengtality opened this issue 2 years ago • 6 comments

Description (REVISED)

Given the gateway balance issue below, I propose the following modifications to this bounty:

  1. Change gateway balance so that it reports balances for each connector (exchange_chain_network), rather than each chain_network. It should use the designated wallet for that connector that the gateway connect command lists.

  2. The output of this command should be a table of balances and allowances for each connector. In addition to the native token, it should also show any tokens that the user adds via gateway connector-tokens.

Connector: uniswap_ethereum_mainnet
Wallet: 0x...

Symbol Balance Allowancce
ETH
HBOT 
WETH
  1. Accept an optional connector parameter in the form of exchange_chain_network. In that case, the command only reports balances and allowances for that connector.

This would remove the need for a separate gateway allowance command.

Bounty

  • Sponsor: Hummingbot Foundation
  • Bounty amount: 50,000 HBOT
  • Developer portion: 100%
  • Allocation: Chain - Ethereum

fengtality avatar Jan 11 '24 22:01 fengtality

I will take this

isreallee82 avatar Jan 11 '24 22:01 isreallee82

Hey @isreallee82 - I realized that we should pause and rethink these changes to gateway balance and wanted to let you know before you do more work on this PR and the new allowances bounty. The reason is that I didn't consider the case where users add different wallets for different connectors on the same network.

Screen Shot 2024-01-12 at 5 21 41 AM

In this case, gateway balance would only show balances for the first connected wallet, and there's no way for users to see balances for the second wallet.

I'll think about this a bit more and address what should be done in this bounty.

fengtality avatar Jan 12 '24 13:01 fengtality

Oh true! Okay @fengtality

isreallee82 avatar Jan 12 '24 13:01 isreallee82

@isreallee82 I revised the description to describe what I think should be done to clean this up.

fengtality avatar Jan 12 '24 14:01 fengtality

alright @fengtality noted!

isreallee82 avatar Jan 12 '24 18:01 isreallee82

pr #6787 @nikspz @fengtality

isreallee82 avatar Jan 16 '24 23:01 isreallee82

Thanks for your participation, the bounty has been sent to @isreallee82. The fix has been deployed on development branch and hummingbot version 1.27.0

nikspz avatar Apr 29 '24 10:04 nikspz