hummingbot
Upgrade Coinbase spot connector
Feature Suggestion Update Coinbase connector. Coinbase closed its 'CoinbasePro' API and relies on the 'Advanced Trading API'.
Impact This is likely to break the current Coinbase Pro connector
@MementoRC Do you want to work on this one? What's the things you need to do for the refactor?
I could give it a try, I had started looking into it with the template. The Advanced Trading AP is completely new, with many methods changed/replaced. Some devs have complained on their dev forum, so I was letting the dust settle
hi @MementoRC Could you please add any updates here? how's it going? are you working on it/will be working on it?
Hi @nikspz , I have started the pre-work. I am progressing a bit slowly due to concurrent items on my plate.
Severity: P2 Bounty: 50,000 (https://hummingbot.org/maintenance/bugs/) Rationale: Community bounty related to bronze connector (connector needs API update)
We'd like to take up this development bounty - Coinbase connector. Me and @manibandi. I have previously contributed BitMart to Hummingbot, and have a lot of experience developing connectors and strategies in private.
Hey @MementoRC could you please update us with your progress on this Bounty?
@nikspz Most of the implementation is completed. A few details are still investigated due to gaps in their documentation and unavailability of sandbox. Currently going through the tests as pipe-cleaning. Should I make a PR (which will fail) for early review?
This bounty will be increased to 250K HBOT since the connector need huge refactor to advanced trade v2 API
https://snapshot.org/#/hbot-ip.eth/proposal/0x62d8feacfd0b69ab37576b9dd2304f648a23216d6e48eb8d9d50ff06fe86e90c
Very nice. Note that Coinbase is actively adding features to their API, as it's being developed (like a REST method for order book snapshot, heartbeats for websocket, new channels). This may trigger modifications to this PR Thank you
This bounty increased to 250K HBOT according to https://snapshot.org/#/hbot-ip.eth/proposal/0x62d8feacfd0b69ab37576b9dd2304f648a23216d6e48eb8d9d50ff06fe86e90c
and since the connector need huge refactor.
Description
- Proposal: HGP-30 (https://snapshot.org/#/hbot-ip.eth/proposal/0x62d8feacfd0b69ab37576b9dd2304f648a23216d6e48eb8d9d50ff06fe86e90c)
- Description: Upgrade Coinbase spot connector to the latest exchange API and connector standard
- Acceptance criteria: Upgrade connector to latest connector standards: https://docs.hummingbot.org/developers/connectors/#what-are-exchange-connectors
Bounty
- Sponsor: Hummingbot Foundation
- Budget: Epoch 5 Budget
- Bounty amount: 250,000 HBOT or USDC equivalnet
- Developer portion: 100%
- Status: Assigned to MementoRC
Note that there should be 2 Coinbase connectors: Advanced Trade and Pro (which is used by institutional investors on Coinbase Exchange accounts) Thank you
I think we only need support for Advanced Trade
On Thu, Jul 27, 2023, 9:36 AM MementoRC @.***> wrote:
Note that there should be 2 Coinbase connectors: Advanced Trade and Pro (which is used by institutional investors on Coinbase Exchange accounts) Thank you
— Reply to this email directly, view it on GitHub https://github.com/hummingbot/hummingbot/issues/6024#issuecomment-1653969095, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANWHVR7BBLNKB3HQU2RK2DXSKKKFANCNFSM6AAAAAAUEAJDNM . You are receiving this because you commented.Message ID: @.***>
- Closed the https://github.com/hummingbot/hummingbot/pull/6458
- unassigned Memento from bounty since connector since pr doesn't met our connector v2.1 standart
- could read comment related there https://github.com/hummingbot/hummingbot/pull/6458
I'd submit that the primary deviation is in the websocket proposal. This part is mostly reverted in my workspace.
Would it be helpful to update with that correction?
On Wed, Feb 28, 2024, 12:33 PM nikspz @.***> wrote:
- Closed the #6458 https://github.com/hummingbot/hummingbot/pull/6458
- unassigned Memento from bounty since connector since pr doesn't met our connector v2.1 standart https://hummingbot.org/developers/connectors/spot-connector-checklist/#directory-setup
- could read comment related there #6458 https://github.com/hummingbot/hummingbot/pull/6458
— Reply to this email directly, view it on GitHub https://github.com/hummingbot/hummingbot/issues/6024#issuecomment-1969596623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWGZEZ4POISLKMEKOHVKFS3YVYRHBAVCNFSM6AAAAAAUEAJDNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRZGU4TMNRSGM . You are receiving this because you were mentioned.Message ID: @.***>
Hello @MementoRC the reason was based on the PR changes 99 files and using (new) redundant changes that not met connector standart as mentioned above. From this solution, unfortunately it can't be merged into HB codebase to not create a case when it's hard to maintain connector (that built not with our latest standarts).
Description
- Proposal: HGP-30 (https://snapshot.org/#/hbot-ip.eth/proposal/0x62d8feacfd0b69ab37576b9dd2304f648a23216d6e48eb8d9d50ff06fe86e90c)
- Description: Upgrade Coinbase spot connector to the latest exchange API and connector standard
- Acceptance criteria: Upgrade connector to latest connector standards: https://docs.hummingbot.org/developers/connectors/#what-are-exchange-connectors
- Connector pots
Discussed to increase bounty amount for this bounty
Bounty
- Sponsor: Hummingbot Foundation
- Budget: Epoch 5 Budget and Connector pots
- Bounty amount: 450,000 HBOT
- Developer portion: 100%
- Status: Assigned to MementoRC
Thanks for your participation, the bounty has been sent to @MementoRC. The connector has been deployed on development branch and hummingbot version 1.27.0. https://hummingbot.org/exchanges/coinbase-advanced-trade/