hummingbot
Feat/cardano
Before submitting this PR, please make sure:
- [x] Your code builds clean without any errors or warnings
- [x] You are using approved title ("feat/", "fix/", "docs/", "refactor/")
A description of the changes proposed in the pull request: Adding a new chain for the Cardano Blockchain along with Minswap & Sundaeswap dex. Allow users to trade and add/remove liquidity on AMM on these Cardano Dexs.
Tests performed by the developer: Manual testing as well as Unit testing. path for test cases: test/chains/cardano path for AMM tests Minswap: test/connectors/minswap path for AMM tests Sundaeswap: test/connectors/sundaeswap
Tips for QA testing:
Can execute swap, add and remove liquidity in both Cardano Dex.
Note that Gateway is in the middle of a big refactor outlined in: https://github.com/hummingbot/gateway/pull/467. v2.8 is slated for release in August.
There are more changes coming wrt to the Hummingbot-Gateway interface, esp for sending and confirming transactions. As this interface needs to be designed to fit Ethereum and Solana chains and wallets, we will defer reviewing and merging PRs for non EVM and non SVM chain architectures until a later date, yet to be announced. In the meantime, I encourage you to keep your fork up to date with the changes in v2.8 and subsequent releases.
Thanks for the contribution!
If you resolve the conflicts (likely related to final v2.8 changes), I will review and test.
Thanks for the contribution!
If you resolve the conflicts (likely related to final v2.8 changes), I will review and test.
HI @fengtality, we have resolved the conflict, code is ready to merge.
Given that there's custom libs being imported, we need to verify that the DEXs and Cardano themselves are supportive of this connector. Otherwise, there's too many security risks for us to import these libs.
"@aiquant/lucid-cardano": "^0.10.11",
"@aiquant/minswap-sdk": "^0.0.0",
"@aiquant/sundaeswap-core": "^1.2.10",
"@blockfrost/blockfrost-js": "^5.7.0",
Please have the folks behind this PR reach out to me on the Hummingbot Discord or Twitter @fengtality.
Given that there's custom libs being imported, we need to verify that the DEXs and Cardano themselves are supportive of this connector. Otherwise, there's too many security risks for us to import these libs.
"@aiquant/lucid-cardano": "^0.10.11", "@aiquant/minswap-sdk": "^0.0.0", "@aiquant/sundaeswap-core": "^1.2.10", "@blockfrost/blockfrost-js": "^5.7.0",Please have the folks behind this PR reach out to me on the Hummingbot Discord or Twitter @fengtality.
Blockfrost is not a custom lib it is a of chain node connector for Cardano, majorly used for on chain operations. As this is a dex we can interact directly with the dexs and make trades there, If the issue with the libs is there let's have a discission on discord regarding this thank you for your id, I will reach out. As we are developing the libs and keeping it up to date with core libs like sudeswap-core and minswap-sdk and lucid-cardano. Blockfrost is a Cardano blockchain library to connect to an remote node provided as a service, it is actively maintained by other developer in Cardano and is one of the core libraries in off chain to on chain connectors.