pyfispot icon indicating copy to clipboard operation
pyfispot copied to clipboard

This application is vulnerable

Open ChiChou opened this issue 7 years ago • 1 comments

There's a easy exploiting vulnerability in: https://github.com/humitos/pyfispot/blob/master/raspberrypi/home/pi/apps/pyfispot/main.py#L69

A fake X-Real-IP header will execute arbitrary command on the server

ChiChou avatar Jan 09 '18 07:01 ChiChou

Thanks for your report. You are right.

We will need to validate that the request.remote_addr is a valid IP. Maybe with a regex? Would you like to propose a PR for this?

humitos avatar Jan 09 '18 14:01 humitos