Manuel Kaufmann

Results 1301 comments of Manuel Kaufmann

I marking this PR ready for review so I can get a new review round here. I'm happy with the current pattern and I think we should start testing it...

I tested this in https://docs--11279.org.readthedocs.build/en/11279/ and I found we need to hide the sections if we don't have content on them: ![Screenshot_2024-04-16_17-51-52](https://github.com/readthedocs/sphinx_rtd_theme/assets/244656/844480b9-a5dc-43b9-bcb2-5c9ecfd394ec) Also, the "Search" input is not shown. The...

Getting close 👍🏼 ![Peek 2024-04-16 18-43](https://github.com/readthedocs/sphinx_rtd_theme/assets/244656/a918f81e-0898-4d5d-a99f-13a60fb67f0c)

> Not sure how complete this is, I didn't test this locally. But this seems on the right path It's great knowing that we are going in the right direction....

With the latest changes, it looks great to me! I think we are ready to merge https://github.com/readthedocs/readthedocs.org/pull/11279 so we can start testing it out in our documentation. ![Screenshot_2024-04-17_13-43-59](https://github.com/readthedocs/sphinx_rtd_theme/assets/244656/2d216e60-0490-450e-99f4-5c556fd8f725)

I made the requested changes 👍🏼 . It seems everything keeps working fine: https://docs.readthedocs.io/en/latest/

Failing tests are unrelated with the changes on this PR. It seems the latest Sphinx/docutils version changed something in the HTML structure and we will need to update our test...

@agjohnson can you take a look at this PR? I'd like to move forward with an alpha release, so we can start testing it with some particular users.

Cool! I'm merging this PR now. We can coordinate the release of an alpha/beta version after that 👍🏼

@saurabheights can you reproduce this issue with the latest release candidate `2.1.0rc1`?