Manuel Kaufmann

Results 1301 comments of Manuel Kaufmann

This is something that users can achieve with `build.jobs.post_checkout` to fetch the tags since it only affects projects using setuptools-scm.

> git tags/history should almost always be checked out/fetched when getting a git repository. I think this is what we want to avoid on the general use case because it...

Without jumping too much on this yet: 1. for some reason the build is not being reset properly when it's retried. We have code that cleanup all the notifications: https://github.com/readthedocs/readthedocs.org/blob/0a381a7acfc7683755ad0af3ad652c3b2f73fe25/readthedocs/builds/models.py#L1092-L1109...

> On the current dashboard there are no notifications though, not sure why. > [readthedocs.org/projects/xclim/builds/23494705](https://readthedocs.org/projects/xclim/builds/23494705/) I think this is because we implemented permissions on notifications in the last deploy (see...

> Also not sure why the string interpolation fails for these, I've noticed that in a few spots though. ```python In [12]: Notification.objects.filter(message_id=BuildMaxConcurrencyError.LIMIT_REACHED, format_values={}).count() Out[12]: 4595 In [13]: Notification.objects.filter(message_id=BuildMaxConcurrencyError.LIMIT_REACHED).exclude(format_values={}).count() Out[13]:...

> I suppose also these should be warning level notifications? That would at least help make it clear that the build is not failed. I've done this in https://github.com/readthedocs/readthedocs.org/pull/11196

> Shouldn't these notifications clear after the build is successfully started? Yes, I've mentioned this in 1) from my previous comment https://github.com/readthedocs/readthedocs.org/issues/11131#issuecomment-1956118651

> So, working on 2) to call `.add()` should be the first point to attack here. I suppose we should overwrite the `api.v2.NotificationSerializer.save()` method to call our custom `.add()`. This...

Now, with the two PRs I've opened I think this issue shouldn't be an issue anymore. However, 1) could be still present sometimes due to network issues/web instance congestion or...

> what I would expect here is that while the build is still queued that warning message should show, but once the build is no longer queued due to concurrency...