Manuel Kaufmann

Results 1301 comments of Manuel Kaufmann

This is ready for review now 👍🏼

I think this emails are also good opportunities to add extra content valuable for the user: - suggestions related to the error - tips about the build itself - new...

@mgeier > I'm not against additional environment variables, those could be very handy in some situations, but I wanted to mention that the RTD build process already provides some (all?)...

@benjaoming I wouldn't use the word `GIT` in the variables, I think it just add noise and we currently support other as well. Yes, we want to deprecate them too...

@stsewd this problem is solved since our js file auto-loads jQuery now, right? This work was done in https://github.com/readthedocs/readthedocs.org/pull/9861

I'm not 100% sure about the potential issues of using `shell=True` here. @agjohnson @ericholscher are you aware of them? @ericholscher I saw you put this in my sprint, but I...

This is related to #10103 and it may be fixed by the PR associated as well.

This error happens because we wrap the command as ``` f"/bin/bash -c '{command}'" ``` https://github.com/readthedocs/readthedocs.org/blob/bc4bceda2a55497ee07a5a470f1a0d54200c6873/readthedocs/doc_builder/environments.py#L386-L401 So, using `'` inside user's commands is tricky. Knowing this, you should be able to...

@ericholscher yeah, I know it's not the best solution 😄 . I commented here since I found _the exact reason_ of the problem now. From there, we can figure it...

@ThiefMaster you can put your command/script into a file and run it from Read the Docs as mentioned in https://github.com/readthedocs/readthedocs.org/issues/9397#issuecomment-1173795211 as a workaround.