mail icon indicating copy to clipboard operation
mail copied to clipboard

Message reaction

Open buddh4 opened this issue 4 years ago • 12 comments

Message reactions as like/emojis

buddh4 avatar Sep 11 '20 16:09 buddh4

A small selection like this one (or just a thumbs up) would be useful:

image

Semir1212 avatar Apr 02 '24 13:04 Semir1212

@Semir1212 maybe I could have a try to add the like module, which allows using the https://marketplace.humhub.com/module/reaction/description module.

marc-farre avatar Apr 02 '24 13:04 marc-farre

@marc-farre That sounds like a good idea, even if I think it should ultimately be part of the Messenger module itself.

Semir1212 avatar Apr 02 '24 14:04 Semir1212

@Semir1212 Maybe we could later merge the Reaction module into HumHub core.

I'll try to work on this issue as soon as possible.

marc-farre avatar Apr 02 '24 15:04 marc-farre

Hello, reactions (https://marketplace.humhub.com/module/reaction/description) work for HumHub Messenger module?

latamclick avatar May 07 '24 17:05 latamclick

@luke- PR https://github.com/humhub/mail/pull/388 adds "Like" to message entries.

image

I had to make AbstractMessageEntry extends ContentActiveRecord instead of ActiveRecord.

And because of that, I had to rename the content column to entry_content in the message_entry table. Let me know if you have a better idea for entry_content. I think it should be called message (as for Post and Comment), but it would be confusing with the message parent table.

@Semir1212 @latamclick Once this new version of the Mail module will be released, I'll release a new version of the Reaction module to work with it.

marc-farre avatar May 08 '24 13:05 marc-farre

Commit https://github.com/humhub/mail/pull/388/commits/99eff0473d5b85981a1c652f7a4ed3e253714cc4 also fixes this issue (founded by automatic tests): Notification not sent to the participant added to the conversion

By fixing this issue, I've discovered another one: https://github.com/humhub/mail/issues/389

marc-farre avatar May 08 '24 13:05 marc-farre

@marc-farre Hmm, Messages from Mail module should not actually be derived from the “ContentActiveRecord”. I'm not sure how best to proceed here.

We will probably have to modify the Like module so that it does support non-content as well.

luke- avatar May 08 '24 14:05 luke-

@luke-

  • PR to allow Like on non-content: https://github.com/humhub/humhub/pull/7002
  • PR for the Messenger module: https://github.com/humhub/mail/pull/391

I have created the LikeNotificationInterface interface. And I had to extend the Like model from ActiveRecord instead of ContentAddonActiveRecord.

Test: image

Result: image

image

There is an issue with emojis, but I don't think it's related to these PRs. I'll do more tests later about it.

Let me know what you think about it. I haven't done a lot of tests at the moment. I would first want to know if I'm going the right direction.

Codeception tests on the Messenger module cannot work without first merging the PR for the core.

marc-farre avatar May 13 '24 18:05 marc-farre

@marc-farre https://github.com/humhub/mail/issues/188#issuecomment-2108561359 This module is already available for download?

latamclick avatar May 13 '24 19:05 latamclick

This module is already available for download?

@latamclick No, it's under development, but unfinished. It will be available when this issue is closed and the new versions of HumHub and Messenger module are released. It might take time.

marc-farre avatar May 13 '24 19:05 marc-farre

Bumping this too.

ilMagnifico avatar May 23 '24 10:05 ilMagnifico