humhub
Make it possible to set notifications even more detailed - additional to global settings within group settings
Is your feature request related to a problem? Please describe.
There are different companies with own public (with private and public content) and private spaces within my network. I would like to set notifications for the public space (with private and public content) the way that only members of the user group of the company will get notifications. At the moment this is not possible because even if you are not a member of a public space you will get notifications from that space if this space is added within settings/notifications by admin.
Describe the solution you'd like
I think it would be great to make it possible to set notifications more detailed. Additional notification settings could be integrated for groups in the group-settings for example.
Like: All members of this group will get notifications from these spaces.
This would have the same logic as with space membership. You have global space membership options in spaces/settings and specific ones in user/groups.
Same could be that you have global notifications settings in settings/notificatios and specific ones in user/groups.
This would also provide a much better overview. In my scenario I would have hundreds of spaces for which to sent notification in one place.(settings/notificatios) To place it in groups as well would it make much clearer.
Describe alternatives you've considered
After thinking for a while I came up that place it into the groups settings would be the very best solution to have the desired effect.
@JK742020 Let me know if I am rephrasing the problem correctly:
The issue is about public spaces added in "Administration" -> "Settings" -> "Notifications" -> "Receive 'New Content' Notifications for the following spaces":
Problem: users which are not a member of these spaces are notified about new content.
Request: Only users which are a member of these spaces are notified.
Advanced request: When using the "Groups associated with Space Categories" module, only users which are a member of these spaces OR not a member of the spaces which are in a Space Category associated with their Group are notified.
If my understanding is correct, I would say the advanced request is too complicated, but the simple request could be an option such as:
In this case, we need to prevent from adding spaces for which we are not a member of (and remove existing ones) in "Receive 'New Content' Notifications for the following spaces".
Hey @marc-farre thanks for rephrasing. Sounds good. What I don't understand is "In this case, we need to prevent from adding spaces for which we are not a member of (and remove existing ones) in "Receive 'New Content' Notifications for the following spaces".
What I don't understand is "In this case, we need to prevent from adding spaces for which we are not a member of (and remove existing ones) in "Receive 'New Content' Notifications for the following spaces".
I mean in the user settings, e.g. https://community.humhub.com/notification/user
@luke- do you agree if I add the "Restrict new content notification to space members only" checkbox in the global admin -> Notification settings (/notification/admin/defaults)?
I will also prevent users from adding spaces for which they are not a member of (and remove existing ones) in:
- the user account settings -> Notification Settings (/notification/user)
- and in the Space dropdown menu "Receive 'New Content' Notifications for the following spaces".
I could add this to 1.18.
@marc-farre Hmm, not sure about this.
Why shouldn't a user be able to be informed about public “new content” from a Space of which they are not a member?
We basically still need to rethink the NewContent Notification, as it makes more or less sense depending on the content type.
Why shouldn't a user be able to be informed about public “new content” from a Space of which they are not a member?
@luke- If you have spaces where notifications are activated by default users get notifications just by becoming member of this certain space. If you are not a member you shouldn't get notifications. The only way to make this happen is to set notifications in the settings for all spaces which should have this behaviour. Let's say you have 10 Spaces like this and Person A becomes member of one of this spaces he/she will get notifications from that certain space and from all the other ones as well. This should not be the case. Person B becomes Member of another of the 10 Spaces and should only get notifications from this space. With "Restrict new content notification to space members only" checkbox notifications could be defined more precisely.
@luke- I also see the use case for this. Some spaces of our instances are quite distinct. Say we have a cat space and a dog space.
If you sign up to access the content of the cat space you don't want to see a lot of notifications that are unrelated to your interest in cats.
@marc-farre https://github.com/humhub/humhub/issues/7043#issuecomment-2585389916
"Restrict new content notification to space members only"
I agree 100% with this idea. I am precisely coding a custom module to add more or less such feature to our site.
Would be much better if it could be implemented in the core
I would also suggest to add this setting in the "space setting" form
We would be interested in this feature request either as a add on module or within the core.
By the way I ask myself the following question:
When you select a space in admin > Setting > Notifications
How does this setting interact with space security settings?
I guess that if the space is 100% private (visibility == private && Default content visibility == private) notifications will not be sent to all site users, but only to space members.
Could someone confirm my guess?
@Gilbertdelyon in older versions of HumHub users also received notifications from privat spaces as well. I told @marc-farre and he made an Issue. I don't know where to find it right now but it was fixed so that newer versions of humhub only send notifications
- to people who are member of the space (privat space and public space) if the space is selected in admin > Setting > Notifications
- and, this is what we try to change, also to people who are not member of a public space if this space is selected in admin > Setting > Notifications
I have just made some tests as follows:
- Create a new space and add it to admin > Settings > Notifications
- Add a few members to this space
- Impersonate these members one by one and check user > settings > notifications
BIG SURPRISE: not all of them have this new space in their notifications setting. It depends on what they have previously set before you add this new space:
- if the member notifications are set "by default" : that's OK, the new space is added
- if the member has already custromised his notification settings: it doesn't work. The new space isn't added.
So, adding a space to admin > setting > notifications doesn't mean all members will be notified. And this is not the way I am looking for. In my mind the space notificaton should be added to all space members in any case, and then the members can remove it or leave it.
@Gilbertdelyon I like the idea "to add this setting in the "space setting" form" as described here https://github.com/humhub/humhub/issues/7043#issuecomment-2611123529 what do you think @marc-farre?
1/
We basically still need to rethink the NewContent Notification, as it makes more or less sense depending on the content type.
@luke- yes, I agree, this is another issue: notifications are sent for each file added to the File module, or each image added to the Gallery module, which can create a lot of notifications.
2/ In the Space settings, add a new checkbox "Restrict new content notification to space members only"
I think this idea is even more complex than https://github.com/humhub/humhub/issues/7043#issuecomment-2585389916
Because when a user visit they Account settings -> Notification Settings (/notification/user), and try to add a Space to the list, it will get confusing to see that some Public spaces can be added, and others not. And they have no way to understand the reason of it, so they will think it's a bug.
So I would say that, if it's a good idea, it should be a global setting, and not per space.
However, this implementation is not easy, adds complexity to HumHub, requires adding self tests, and there are a lot of other important topics.
@luke- perhaps an alternative would be to add an Event somewhere, to allow solving this issue via a custom module. If you think it can be an idea, I'll take a look at the code to see what would be possible.
Hmm, not sure what I prefer here. Probably an event or configuration option would be best.
@luke- @JK742020 PR https://github.com/humhub/humhub/pull/7421
I consider this PR as experimental. I would require adding self tests, but I'm missing time for that. Also, I think it adds complexity to the code, which is already complex for notifications.
So I won't merge it as it is in Develop.
@luke- @JK742020 @samuk @Gilbertdelyon @atdqm I have created a module for solving this issue: https://github.com/cuzy-app/alt-notification
@luke- I you want it to be on the Marketplace, let me know. But it's a very special module, so not sure. However, I'm OK if you think it's good idea. It's a module I will maintain in the time.
Closing PR https://github.com/humhub/humhub/pull/7421 because I think it adds too much complexity to the core.
You are welcome to add it to the Marketplace, even if it is very special. Apart from that, I hope we can revise the notification topic again soon.
@Gilbertdelyon thanks for warning me. I forgot to make the repo public. Done!
You are welcome to add it to the Marketplace, even if it is very special.
@luke- thanks. I'll wait for a few weeks to have feedbacks, and then I'll upload it on the Marketplace.
@Gilbertdelyon and others: if you see any issues, don't hesitate to report them on https://github.com/cuzy-app/alt-notification/issues Thanks!
@marc-farre new alt-notification module works perfectly! Thanks a lot. https://github.com/cuzy-app/alt-notification