setup-vulkan-sdk icon indicating copy to clipboard operation
setup-vulkan-sdk copied to clipboard

Add input to specify windows architecture target to build vulkan-1.lib

Open LittleCoinCoin opened this issue 2 years ago • 1 comments

Hello,

I know it's probably a minor set of the users but I needed to make sure that my project using Vulkan would also compile for Win32. This didn't seem to be covered by your action as I understood everything was set to x64 by default; I hope I didn't miss anything. If you think it's too specific, feel free to leave it pending. At least, I wanted to share my solution for the few people that might be interested.

I added an optional input to be able to select x64 or Win32 with a description mentioning that this is relevant for windows only. Then, there is a catch: vsdevenv can be set with x86 but not Win32, so I added a step in the action to translate the arch to x86 in the only case that user want to set up vulkan for Win32.

The windows test for powershell was replaced with a test including the arch.

P.S. I am sorry, the intermediate tests were a bit messy and I didn't know about action-tmate until 10min ago...

LittleCoinCoin avatar Jul 30 '23 07:07 LittleCoinCoin

(half a year later... apologies for delay reviewing!)

This is really great! In the back of my mind I remember wanting to keep the x64 specifier near to the surface -- so that one day x86 support could be revisited. I am very glad you were able to figure out a working recipe and get it working.

For now I will plan on leaving this PR open as a reference and hope to find more time coming up to look into the best way to integrate/merge the enhanced feature into mainline. Thanks!

humbletim avatar Feb 08 '24 18:02 humbletim