setup-vulkan-sdk icon indicating copy to clipboard operation
setup-vulkan-sdk copied to clipboard

Published 20 hours ago • verified publisher icon humbletim

fix github actions deprecation warnings + preflight checks

Open humbletim opened this issue 3 years ago • 2 comments

  • update action dependencies to avoid deprecation warnings
  • add more error checking and preflight checks around SDK webservice assumptions

humbletim avatar Oct 23 '22 18:10 humbletim

reference points:

  • actions/cache: https://github.com/actions/cache/issues/953
  • actions/checkout: https://github.com/actions/checkout/issues/959
  • seanmiddleditch/gha-setup-vsdevenv: https://github.com/seanmiddleditch/gha-setup-vsdevenv/pull/15

humbletim avatar Oct 23 '22 19:10 humbletim

preflight checks TODO:

  • [x] improved detection and reporting of webservice errors (including webservice internal error message when available) -eg: specifying "bogus" for the SDK release number: image
  • [ ] verify config.json ducktypes as a valid Vulkan SDK config before attempting to use

humbletim avatar Oct 27 '22 19:10 humbletim

Could we merge this? @humbletim

edvn0 avatar Feb 23 '23 07:02 edvn0

Guess a year between reminders is ok @humbletim

dsvensson avatar Jan 11 '24 16:01 dsvensson

Can you merge this @humbletim ?

kalwalt avatar Feb 05 '24 13:02 kalwalt

Hi.. I am (somewhat) back again and in any event planning to get this PR merged this week. Apologies for the delay. Also if anyone is interested in adopting lead responsibility for the project or helping to co-maintain please let me know.

humbletim avatar Feb 06 '24 09:02 humbletim

Hi.. I am (somewhat) back again and in any event planning to get this PR merged this week. Apologies for the delay. Also if anyone is interested in adopting lead responsibility for the project or helping to co-maintain please let me know.

Don't worry. I could help you out 😃

edvn0 avatar Feb 06 '24 10:02 edvn0

Hi.. I am (somewhat) back again and in any event planning to get this PR merged this week. Apologies for the delay. Also if anyone is interested in adopting lead responsibility for the project or helping to co-maintain please let me know.

Thank you @humbletim ! This is awesome!

kalwalt avatar Feb 06 '24 15:02 kalwalt

Hi everyone!

There seems to be a recent issue building SPIRV-Tools on macOS. While unrelated to this PR, I typically run a final "CI build" on different platforms before releasing. Unfortunately, Mac builds are failing for all but the the latest SDK version, apparent due to sprintf-related warnings being promoted into errors by compile flags somewhere. Which for older releases should not have changed... but could have for example on LunarG webservices config.json side of the equation.

To understand the scope of the problem, I'd appreciate it if anyone using the SDK on Mac could share:

  • Which SDK version are you targeting?
  • Have you encountered any recent build failures related to sprintf?

I'm planning to merge this PR to "main" later tonight after one final non-mac-legacy CI test, but am thinking to hold off on stamping an official release tag until I have a clearer picture of the Mac issue. Once I gather more information, I plan to file an issue report and potentially involve relevant teams for a resolution.

Thanks for your input!

humbletim avatar Feb 10 '24 00:02 humbletim