google_map_location_picker icon indicating copy to clipboard operation
google_map_location_picker copied to clipboard

null safety support

Open modekano opened this issue 3 years ago • 12 comments

4.1.7 is not support null safety! after upgrade to flutter 2.0.1 this package show error regarding null safety

modekano avatar Mar 09 '21 21:03 modekano

Hello,

Indeed... @humazed , could you update your dependencies?

Because google_map_location_picker >=4.1.3 depends on geolocator ^6.1.14 which depends on geolocator_platform_interface ^1.0.8, google_map_location_picker >=4.1.3 requires geolocator_platform_interface ^1.0.8.
And because geolocator_platform_interface <2.0.0-nullsafety.0 depends on plugin_platform_interface ^1.0.2, google_map_location_picker >=4.1.3 requires plugin_platform_interface ^1.0.2.
And because cloud_firestore >=1.0.0 depends on cloud_firestore_platform_interface ^4.0.0 which depends on plugin_platform_interface ^2.0.0, google_map_location_picker >=4.1.3 is incompatible with cloud_firestore >=1.0.0.
So, because bubble_pro depends on both cloud_firestore ^1.0.0 and google_map_location_picker ^4.1.7, version solving failed.
pub get failed (1; So, because bubble_pro depends on both cloud_firestore ^1.0.0 and google_map_location_picker ^4.1.7, version solving failed.)

davemg3 avatar Mar 15 '21 20:03 davemg3

I update all dependencies, but still it show error in /google_map_location_picker/lib/ code, all errors regarding null value checking.

modekano avatar Mar 15 '21 21:03 modekano

For now, i have forked it and updated Geolocator methods as required by Geolocation 7.0.0.

For example methods checkPermission() or getCurrentPosition() became Geolocator.checkPermission() or Geolocator.getCurrentPosition() You can see it in https://github.com/davemg3/google_map_location_picker.git file : lib/src/google_map_location_picker.dart It is enough for me compiling with latest dependencies integrating nullsafety.

Temporary solution : Waiting for owner to update its project.

davemg3 avatar Mar 15 '21 22:03 davemg3

@davemg3 Please create a pull request so we can review?

KgotsoK avatar Mar 17 '21 19:03 KgotsoK

I just took a look at a possible port and even tough @davemg3 already started, there is still a lot to do and also decisions to be made which var to still be nulllable etc. So, @humazed if you could take a look that would be awesome.

jlnrrg avatar Apr 10 '21 15:04 jlnrrg

Any news please ?

OrionWambert avatar Apr 24 '21 11:04 OrionWambert

I think we can safely assume that this package is dead.

KgotsoK avatar May 10 '21 19:05 KgotsoK

+1

blbhargav avatar May 23 '21 16:05 blbhargav

I forked this project and upgraded to null safety. Use this as your dependency.

google_map_location_picker:
    git:
      url: https://github.com/blbhargav/google_map_location_picker.git
      ref: null_safety

I also made a pull request. #167

blbhargav avatar Jun 22 '21 07:06 blbhargav

For now, i have forked it and updated Geolocator methods as required by Geolocation 7.0.0.

For example methods checkPermission() or getCurrentPosition() became Geolocator.checkPermission() or Geolocator.getCurrentPosition() You can see it in davemg3/google_map_location_picker.git file : lib/src/google_map_location_picker.dart It is enough for me compiling with latest dependencies integrating nullsafety.

Temporary solution : Waiting for owner to update its project.

@davemg3 can I trouble you to update it to embedding v2 if possible

Srini-B avatar Sep 16 '21 10:09 Srini-B

+1

DanielSmith1239 avatar Dec 12 '21 16:12 DanielSmith1239

I released https://pub.dev/packages/map_location_picker with fixed null safety. Could you check that everything works for you?

rvndsngwn avatar May 07 '22 23:05 rvndsngwn