comment-popularity hmn_cp_v121_upgrade() breaks plugin

hmn_cp_v121_upgrade() breaks plugin

Open slavicd opened this issue 7 years ago • 3 comments

$users = get_users(); from hmn_cp_v121_upgrade() breaks for anything more than half a million users throwing out of memory error.

Moreover, the upgrade script always runs because hmn_cp_plugin_version is statically set to 1.2.0 (always)

Sep 12 '17 13:09 slavicd

thanks, I'll take a look

Sep 13 '17 08:09 pdewouters

Moreover, the upgrade script always runs because hmn_cp_plugin_version is statically set to 1.2.0 (always)

It will only set the version to 1.2.0 if it doesn't find the version setting in the DB. OR do you mean on a new install?

Sep 13 '17 08:09 pdewouters

It would always trigger the user upgrade routine because the version would always be 1.2.0 or empty

Sep 13 '17 15:09 slavicd