coding-standards icon indicating copy to clipboard operation
coding-standards copied to clipboard

Reconsider use of eslint-config-react-app

Open pdewouters opened this issue 4 years ago • 1 comments

The react-app config doesn't seem to be updated that often and is probably very opinionated towards apps created with create-react-app

I think it makes sense to take a more generic approach and instead we could use plugin:react/recommended as a base.

Alternatively, we should probably be using https://developer.wordpress.org/block-editor/reference-guides/packages/packages-eslint-plugin/

which is the one used by Gutenberg.

pdewouters avatar Mar 31 '21 14:03 pdewouters

 ├─┬ @wordpress/[email protected]
   └─┬ @wordpress/[email protected]
     └── [email protected]

vs

npm WARN [email protected] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.

Using this package in combination with @wordpress/scripts results in an incompatibility.

svandragt avatar Apr 07 '21 10:04 svandragt