authorship icon indicating copy to clipboard operation
authorship copied to clipboard
verified publisher icon humanmade

Undocumented Node version requirements

Open tomjn opened this issue 3 years ago • 3 comments

Authorship specifies no Node requirements, and will fail if using modern NodeJS. To fix this the package.json should specify the range of Node versions that are supported in the engines section, and it should be mentioned in the readme file

tomjn avatar Nov 16 '22 18:11 tomjn

It's in the .nvmrc file but nowhere else. The whole Node setup needs updating to Node 20 too.

johnbillion avatar Feb 20 '24 17:02 johnbillion

Updating to node 20 is a huge rabbit hole.

I tried making a start and I think my recommendation is a to update the build tooling to use wp-scripts instead, as well as it's eslint, stylelint and other configs. Updating the HM webpack helpers and coding standards is too difficult at this point IMO.

We will need to remove react-sortable-hoc with @dnd-kit as well because the former is no longer maintained.

roborourke avatar Jun 27 '24 12:06 roborourke

As Rob pointed out, the GitHub Actions workflow for the build is not failing either, everything is green. Needs looking into.

johnbillion avatar Jun 27 '24 12:06 johnbillion