altis-core icon indicating copy to clipboard operation
altis-core copied to clipboard

Remove legacy install path overrides for old packages

Open roborourke opened this issue 1 year ago • 4 comments

With removal of some modules and potentially more in future there is a list of legacy packages that Altis will override the installation path for. This should be seen as a bug because it's unexpected and hard to debug behaviour.

https://github.com/humanmade/altis-core/blob/master/inc/composer/class-override-installer.php#L55-L92

The list should be updated and backported, there may be some other packages to remove depending on the Altis version.

Acceptance criteria

  • [ ] Review, test and merge associated PR

roborourke avatar Oct 16 '23 13:10 roborourke

No longer needed

  • humanmade/delegated-oauth (removed in v14)
  • altis/aws-analytics (removed in v17)
  • altis/experiments (not needed as far back as 13)
  • humanmade/meta-tags (not needed as far back as 13)

mikelittle avatar Oct 18 '23 14:10 mikelittle

@mikelittle I made a PR already for this - I think the legacy packages list can just be removed, it was only to support composer v1. May need to remove Composer v1 from the product-dev test matrix too as v2 has been out for some time now.

roborourke avatar Oct 18 '23 15:10 roborourke

The particular issue we have on a project right now is the removal of humanmade/hm-gtm in v17 that was part of the Analytics module and not directly mentioned in the upgrade guide. We're working around it by checking both possible install locations before including it.

roborourke avatar Oct 18 '23 15:10 roborourke

Hey team! Please add your planning poker estimate with Zenhub @ferschubert-hm @jerico @mikelittle @wisyhambolu

kovshenin avatar Mar 13 '24 11:03 kovshenin