S3-Uploads icon indicating copy to clipboard operation
S3-Uploads copied to clipboard

Fatal error with PHP 8

Open tillkruss opened this issue 4 years ago • 8 comments

[01-Dec-2020 21:44:47 UTC] PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in web/app/plugins/s3-uploads/lib/getid3/getid3.php on line 554
[01-Dec-2020 21:45:34 UTC] PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in web/app/plugins/s3-uploads/lib/getid3/getid3.php on line 554
[01-Dec-2020 21:45:35 UTC] PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in web/app/plugins/s3-uploads/lib/getid3/getid3.php on line 554
[01-Dec-2020 21:45:38 UTC] PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in web/app/plugins/s3-uploads/lib/getid3/getid3.php on line 554
[01-Dec-2020 21:45:41 UTC] PHP Fatal error:  Array and string offset access syntax with curly braces is no longer supported in web/app/plugins/s3-uploads/lib/getid3/getid3.php on line 554

tillkruss avatar Dec 01 '20 21:12 tillkruss

@joehoyle @rmccue Can you tag a new release that works with PHP 8?

tillkruss avatar Dec 01 '20 21:12 tillkruss

Thanks for flagging @tillkruss. We don't yet support PHP8, but will address this once we do a pass on our projects for that support.

joehoyle avatar Dec 01 '20 21:12 joehoyle

There is also a deprecation warning in PHP 7.4 for web/app/plugins/s3-uploads/lib/getid3/getid3.php on line 554 and 555

plexus77 avatar Dec 07 '20 23:12 plexus77

Noting that getID3 has already been removed in https://github.com/humanmade/S3-Uploads/commit/9c914ec5ef832342e697633ebc17f6d496d23c30.

ocean90 avatar Dec 10 '20 14:12 ocean90

@ocean90 ah yes, that's in master, though I think didn't get back ported to the v2 branch (which has 5.3 support).

With the fairly chunky changes in https://github.com/humanmade/S3-Uploads/pull/401 I plan to release a 3.0 alpha soon.

joehoyle avatar Dec 10 '20 14:12 joehoyle

@joehoyle Stoked to hear that!

tillkruss avatar Dec 10 '20 16:12 tillkruss

@joehoyle any update on v3.0?

tillkruss avatar Jan 24 '21 22:01 tillkruss

For anyone watching here, v2.3.0 was released without getid3, see #500.

ocean90 avatar Mar 18 '21 15:03 ocean90