Custom-Meta-Boxes icon indicating copy to clipboard operation
Custom-Meta-Boxes copied to clipboard

Published 20 hours ago • verified publisher icon humanmade

Make 'Select File' label translatable

Open barryceelen opened this issue 8 years ago • 6 comments

To the detriment of global fraternisation the ‘Select File’ media view title in file-upload.js remained untranslatable.

barryceelen avatar Aug 29 '16 14:08 barryceelen

@barryceelen I like this and I'm glad we're moving towards more complete translatability! Could you also add a string to the Image field below the file one and straighten out the fatty arrows around line 430 & 516?

Should only need to add 'string-select-file' => esc_html__( 'Select Image', 'cmb' ), to line 517 of classes.fields.php with a comma on the line above.

Thank you!

mikeselander avatar Aug 29 '16 15:08 mikeselander

Okidoki that’s done.

barryceelen avatar Aug 29 '16 15:08 barryceelen

@mikeselander Merge conflicts fixed.

barryceelen avatar Jan 11 '17 11:01 barryceelen

@mikeselander Merged latest changes from develop.

barryceelen avatar Mar 24 '17 16:03 barryceelen

@mikeselander These little untranslated strings (and these) stand out like a sore thumb between their otherwise impeccably translated brethren 😢. Can we put them out of their misery 😉?

barryceelen avatar Sep 20 '17 11:09 barryceelen

Hey @barryceelen sorry for taking so long! I'll do this next week :)

mikeselander avatar Sep 20 '17 15:09 mikeselander