solis-sensor icon indicating copy to clipboard operation
solis-sensor copied to clipboard

Whole number issue back after update to 3.5.2

Open deligatedgeek opened this issue 1 year ago • 6 comments

Probably another Solis API "update", but after upgrading to 3.5.2 only whole numbers are showing in home assistant. See the change on the graph below. Screenshot 2024-04-17 at 10 22 29

Same effect as previous Solis change Screenshot 2024-04-17 at 10 37 22

Versions HA Version: Docker 2024.4 HACS version: 1.34.0 Integration version: 3.5.2

deligatedgeek avatar Apr 17 '24 09:04 deligatedgeek

I think the code should be reverted and the misspelled inveterDetail endpoint should be used. As that endpoint is documented here

deligatedgeek avatar May 02 '24 14:05 deligatedgeek

Hi @deligatedgeek,

Picking up again. Is this problem still there or did they fix the resolution in the meantime? If it's still there then I need to think hard how to proceed as there are some conflicting issues and I do not want to go into cherrypicking data from various endpoints trying to make right what's made wrong by Ginlong Solis. (see https://github.com/hultenvp/solis-sensor/issues/360#issuecomment-2028799757)

hultenvp avatar Aug 29 '24 09:08 hultenvp

I think this was 'fixed' by Ginlong Solis, although I've noticed over the past few days, reported battery charging/discharging is back to whole numbers, with the fraction left over getting caught up in the 23:00-00:00 period. This might be due to the Home Assistant 2024.9 update, as graphs before 4th September do not show the whole number jumps..

image image

jmccomb1979 avatar Sep 12 '24 09:09 jmccomb1979

After running the soliscloud_test.py it seems that the api is returning whole numbers for InverterDetailList. JSON output attached for InverterDetailList and InverterDetail endpoints. datatest1.json datatest2.json

jmccomb1979 avatar Sep 30 '24 14:09 jmccomb1979

Have opened a support ticket for the battery charge/discharge whole number issue, and Solis re-enabled the API access that I already had.....

jmccomb1979 avatar Oct 01 '24 08:10 jmccomb1979

I got a reply -

"We have received the reply as the inverter DetailList is calculated by the SC platform, and inverterList is reported by the inverter, so the two values are different, and the R&D staff recommends using inverterDetailList."

I have a fix being tested which pulls only the battery charge/discharge data from inverterList, but the big fiery ball is not visible in the sky today so I'm not seeing any battery activity atm. If it works, I'll submit a PR.

jmccomb1979 avatar Oct 08 '24 09:10 jmccomb1979

@jmccomb1979 hope you've seen some sunlight since! Any luck fixing this issue? :)

leroyboerefijn avatar Nov 04 '24 11:11 leroyboerefijn

@leroyboerefijn Sadly not. My theory was to use only the battery data from the inverterList endpoint, but my python skills were not up to the task. Attempted to re-do the SoloLearn Python Core course that I had completed 6 years ago, but abandoned it when the example code snippets used in their tutorial questions had no indentation. Pointed it out to them and they said "That one isn't supported any more, use the Python Developer course instead". I've not had the time recently to get back to the course.

jmccomb1979 avatar Nov 05 '24 16:11 jmccomb1979

I have looked at this bug and I am unable to replicate it. Can you confirm if this is still an issue for you? It seems that for my station I recieve a float with data for batteryTodayDischargeEnergy for both the inverterDetail and InverterDetailList. inverterDetail.json inverterDetailList.json

patduckless avatar Dec 16 '24 11:12 patduckless

It's no longer an issue, I've moved to obtaining the data directly from the Modbus connection that the data loggers use.

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg


From: P @.> Sent: Monday, December 16, 2024 11:57:55 AM To: hultenvp/solis-sensor @.> Cc: jmccomb1979 @.>; Mention @.> Subject: Re: [hultenvp/solis-sensor] Whole number issue back after update to 3.5.2 (Issue #367)

I have looked at this bug and I am unable to replicate it. Can you confirm if this is still an issue for you? It seems that for my station I recieve a float for both the inverterDetail and InverterDetailList. inverterDetail.jsonhttps://github.com/user-attachments/files/18149638/inverterDetail.json inverterDetailList.jsonhttps://github.com/user-attachments/files/18149639/inverterDetailList.json

— Reply to this email directly, view it on GitHubhttps://github.com/hultenvp/solis-sensor/issues/367#issuecomment-2545430530, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4FEEQH2CYGZAB2LJG5XIKD2F254HAVCNFSM6AAAAABGK6LHNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBVGQZTANJTGA. You are receiving this because you were mentioned.Message ID: @.***>

jmccomb1979 avatar Dec 16 '24 12:12 jmccomb1979

For me it's still an issue. I updated again from 3.5.1 to 3.8.1 hoping it would be solved but to no avail.

blackspiritus avatar Jan 08 '25 20:01 blackspiritus

Should be fixed in #420 based on data retrieved from other users

hultenvp avatar Feb 08 '25 14:02 hultenvp