gef icon indicating copy to clipboard operation
gef copied to clipboard

Killing more inconsistencies through type hints

Open hugsy opened this issue 1 year ago • 8 comments

Description

This PR is purely esthetic but fixes a few extra inconsistencies thanks to type hints, using pylint and pylance.

Among other fixes:

  • removed unused vars
  • f-string-ify more
  • enforce (using assert) expected type to variable when appropriate
  • fixed some bad type names in gdb.events.*

With this PR :

  • pylint on gef and tests/*.py shows a 10/10 score

image

  • pylance shows some minor warnings and infos

Checklist

  • [x] My code follows the code style of this project.
  • [x] My change includes a change to the documentation, if required.
  • [x] If my change adds new code, adequate tests have been added.
  • [x] I have read and agree to the CONTRIBUTING document.

hugsy avatar Jan 20 '24 21:01 hugsy

🤖 Coverage update for 1c3504e239b39eada3f0153fa4e0c86b5f51f242 🔴

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 1c3504e239b39eada3f0153fa4e0c86b5f51f242
Score 71.7764% 71.6686% (-0.1078)

github-actions[bot] avatar Jan 20 '24 21:01 github-actions[bot]

🤖 Coverage update for 1c3504e239b39eada3f0153fa4e0c86b5f51f242 🟢

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 1c3504e239b39eada3f0153fa4e0c86b5f51f242
Score 71.7764% 71.7959% (0.0195)

github-actions[bot] avatar Jan 20 '24 21:01 github-actions[bot]

🤖 Coverage update for e0c15b14eb5e1c62ac501e10065d1b7ecf8da145 🔴

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 e0c15b14eb5e1c62ac501e10065d1b7ecf8da145
Score 71.7764% 71.6547% (-0.1217)

github-actions[bot] avatar Jan 22 '24 00:01 github-actions[bot]

🤖 Coverage update for e0c15b14eb5e1c62ac501e10065d1b7ecf8da145 🟢

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 e0c15b14eb5e1c62ac501e10065d1b7ecf8da145
Score 71.7764% 71.7764% (0)

github-actions[bot] avatar Jan 22 '24 00:01 github-actions[bot]

🤖 Coverage update for 0b6ad3b11d299c29adc7f3d4869488cff72d2529 🔴

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 0b6ad3b11d299c29adc7f3d4869488cff72d2529
Score 71.7764% 71.5865% (-0.1899)

github-actions[bot] avatar Jan 22 '24 01:01 github-actions[bot]

🤖 Coverage update for 0b6ad3b11d299c29adc7f3d4869488cff72d2529 🟢

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 0b6ad3b11d299c29adc7f3d4869488cff72d2529
Score 71.7764% 71.7764% (0)

github-actions[bot] avatar Jan 22 '24 01:01 github-actions[bot]

🤖 Coverage update for 45caca712a81c68ca9c0c808dfc6579be6edd5be 🔴

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 45caca712a81c68ca9c0c808dfc6579be6edd5be
Score 71.7764% 71.5893% (-0.1871)

github-actions[bot] avatar Jan 22 '24 01:01 github-actions[bot]

🤖 Coverage update for 45caca712a81c68ca9c0c808dfc6579be6edd5be 🟢

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 45caca712a81c68ca9c0c808dfc6579be6edd5be
Score 71.7764% 71.7764% (0)

github-actions[bot] avatar Jan 22 '24 01:01 github-actions[bot]

🤖 Coverage update for 2b11d8376fbd3da243eb2055f81cd3bb3592669d 🟢

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 2b11d8376fbd3da243eb2055f81cd3bb3592669d
Score 71.7764% 71.7959% (0.0195)

github-actions[bot] avatar Jan 25 '24 01:01 github-actions[bot]

🤖 Coverage update for 2b11d8376fbd3da243eb2055f81cd3bb3592669d 🔴

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 2b11d8376fbd3da243eb2055f81cd3bb3592669d
Score 71.7764% 71.5623% (-0.2141)

github-actions[bot] avatar Jan 25 '24 01:01 github-actions[bot]

🤖 Coverage update for 0d9091247326dfc8e8f5536495642d93643d5eb9 🔴

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 0d9091247326dfc8e8f5536495642d93643d5eb9
Score 71.7569% 71.5623% (-0.1946)

github-actions[bot] avatar Jan 25 '24 16:01 github-actions[bot]

🤖 Coverage update for 0d9091247326dfc8e8f5536495642d93643d5eb9 🟢

Old New
Commit 219d46fedcf3859a5509ef2ccacd3396dab28768 0d9091247326dfc8e8f5536495642d93643d5eb9
Score 71.7569% 71.8153% (0.0584)

github-actions[bot] avatar Jan 25 '24 16:01 github-actions[bot]