Hugo Manrique

If the event is deprecated prior to the release of Polymer, I would suggest renaming `ServerPostConnectEvent` to `ServerConnectedEvent` in this version (to avoid confusion and verbose-ness).

The `VelocityConfiguration#read` method needs a rework. Imo, if the secret file doesn't exist, a default one should be created even when the `velocity.toml` file exists (i.e. I would remove the...

That's what I meant, i.e. remove [these lines](https://github.com/PaperMC/Velocity/blob/d8198783739f214917f957ad70a5c3698436d5f5/proxy/src/main/java/com/velocitypowered/proxy/config/VelocityConfiguration.java#L425-L429) (425-429) and add an `else` branch [here](https://github.com/PaperMC/Velocity/blob/d8198783739f214917f957ad70a5c3698436d5f5/proxy/src/main/java/com/velocitypowered/proxy/config/VelocityConfiguration.java#L499) that looks ```java forwardingSecretString = generateRandomString(12); Files.writeString(secretPath, forwardingSecretString); ``` This preserves the behavior prior to...

As the error mentions, the `extract-text-plugin` webpack plugin requires both a plugin instance (passed to the `plugins` array by creating an `ExtractTextPlugin` instance) and a loader instance. You can check...

Whoops! Sorry I missed that. Have you tried passing the `HtmlLoaderPlugin` instance after the `ExtractTextPlugin` one on the `plugins` array?

See https://github.com/VelocityPowered/Velocity/blob/8abc9c80a69158ebae0121fda78b55c865c0abad/proxy/src/main/java/com/velocitypowered/proxy/util/BrigadierUtils.java#L38 for a brute-force solution. Gamebuster's solution is incomplete and only works for nodes with no children. Note that this is **not** a proper fix.

I believe the returned `CompletableFuture` can still complete exceptionally (don't know if this is intended, as you say "just return the results of futures that completed sucessfully") if two or...

My bad, I couldn't find the non-shortcircuit claim on the javadoc since I forgot to read the @returns: _a new CompletableFuture that is completed when all of the given CompletableFutures...

I've just profiled a really small CLI app that takes ~2 seconds to run using the V8 profiler. This package came up as first for compile time. As you say,...

I would wait until I remove the WIP status. As it stands, this is more of a PoC. I'm pretty busy right now, so I don't have much time to...