Richard Hughes

Results 1241 comments of Richard Hughes

I don't think we need this now, right? If we do, please reopen.

> I would think you want to return the FuUSBDevice associated not the GUSBDevice, no? I think that would be misleading and possibly lead to trouble; what happens if we...

Ack, agree. I don't want it to be a workaround for wait-for-replug for instance.

In the example given by Logitech, I think it makes sense to add this.

> If the lifecycle is wrong So my thinking here is that we should never add either the `GUdevDevice` from `fu_usb_device_find_udev_device()` or the `GUsbDevice` from `fu_udev_device_find_usb_device()` as a `FuDevice`-derived device....

> if we enforced that you couldn't use a fu_udev_device_find_usb_device as the input to fu_usb_device_new I added that.

Here you go: processor    : 0 vendor_id    : GenuineIntel cpu family    : 6 model        : 85 model name    : Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz stepping    : 4 microcode    ...

> Additionally, there are no inline resistors and so an external device cannot easily overdrive the SPI signalling Hmm, that's unfortunate. > but as it stands soldering is required I...

@FFY00 should I put a restriction of fwupd >= 1.3.1 on that firmware?