colord icon indicating copy to clipboard operation
colord copied to clipboard

Alarm Code Context

Open doctormo opened this issue 1 year ago • 1 comments

I'm reading through lcms2 to try and get things working and I notice that this code:

https://github.com/hughsie/colord/blob/d0c5a292fa239435bbf80b8c251b5320ad588997/lib/colord/cd-icc-utils.c#L98

Should not work, if lcms2 uses contexts to store the alarm codes. But I find it unlikely that colord has a non-functioning gamut checker, so I'm not sure what to make of that.

Expected code:

cmsSetAlarmCodesTHR(cd_icc_get_context (icc), alarm_codes);

doctormo avatar Jan 19 '24 10:01 doctormo

But I find it unlikely that colord has a non-functioning gamut checker

I know it used to work, but I've not used that code in anger for many years.

cmsSetAlarmCodesTHR(cd_icc_get_context (icc), alarm_codes);

That looks much better entirely -- can you do a PR please.

hughsie avatar Jan 19 '24 10:01 hughsie