appstream-glib icon indicating copy to clipboard operation
appstream-glib copied to clipboard

appstream-glib.pc dependencies are hardcoded

Open samm-git opened this issue 6 years ago • 5 comments

Just found that https://github.com/hughsie/appstream-glib/blob/master/libappstream-glib/appstream-glib.pc.in has hardcoded dependency on uuid, which is not needed on macOS and windows platforms. This should be set by configure instead.

samm-git avatar Jan 18 '20 08:01 samm-git

Probably its good idea to switch to the https://github.com/mesonbuild/meson/blob/master/docs/markdown/Pkgconfig-module.md module, as it seems that such tasks are automated.

samm-git avatar Jan 18 '20 08:01 samm-git

Probably its good idea to switch to the Pkgconfig-module.md module

A PR for this would be most welcome. I did the Meson port before this module existed.

hughsie avatar Jan 20 '20 10:01 hughsie

Ok, will add this to my todo list. I do have very little meson experience, but will try to do that.

samm-git avatar Jan 21 '20 08:01 samm-git

It should look a lot like https://github.com/fwupd/fwupd/blob/master/libfwupd/meson.build#L60 -- right?

hughsie avatar Jan 21 '20 09:01 hughsie

yep

samm-git avatar Jan 21 '20 13:01 samm-git