appstream-glib icon indicating copy to clipboard operation
appstream-glib copied to clipboard

Fix potential buffer underflow and inefficient copy using fnmatch.

Open robert-ancell opened this issue 6 years ago • 2 comments

If length was zero we could check the -1 index. A nul was always added because we only used the length of the string, not the buffer (i.e. off by one). Also remove a check for a negative number from an unsigned number.

robert-ancell avatar Aug 29 '18 04:08 robert-ancell

CI seems to be failing -- can you check than out pls?

hughsie avatar Aug 30 '18 13:08 hughsie

@robert-ancell ?

hughsie avatar Feb 06 '19 12:02 hughsie