persistent-hash-trie icon indicating copy to clipboard operation
persistent-hash-trie copied to clipboard

Pass tests for all supported browsers in ci.testling

Open hughfdjackson opened this issue 11 years ago • 7 comments

As a user, I want to be able to use immutable-hash-trie in any semi-common environment, including:

  • ie 6+
  • chrome 4+
  • FF 3+
  • opera 10+
  • safari 5+
Acceptance:

Test suite passes on ci.testling.com for all currently listed browesrs:

{
  "testling": {
    "files": "test/*-test.js",
    "browsers": [
      "iexplore/6.0",
      "iexplore/7.0",
      "iexplore/8.0",
      "iexplore/9.0",
      "iexplore/10.0",
      "chrome/4.0",
      "chrome/23.0",
      "firefox/3.0",
      "firefox/17.0",
      "opera/10.0",
      "opera/12.0",
      "safari/5.0.5",
      "safari/5.1"
    ],
    "harness": "mocha-qunit"
  }
}

hughfdjackson avatar Mar 19 '13 13:03 hughfdjackson

This may or may not be constrained by ci.testling's reliability :/

hughfdjackson avatar Mar 27 '13 00:03 hughfdjackson

@hughfdjackson consider dropping IE6-8, FF3 & chrome4 support

ImmutableHash seems to work everywhere apart from IE8

Raynos avatar Mar 29 '13 07:03 Raynos

@Raynos I don't see any any inherent barrier to i6 + adoption; although i may have to change the API not to use 'transient', since es3 put that on the future keyword list.

toJSON is, in any case, the de-facto javascript equivalent, even if it is terribly named ;-;.

I take it you don't suspect some ci.testling unreliability in this case?

hughfdjackson avatar Mar 29 '13 13:03 hughfdjackson

I should point out that my test are somewhat data-intensive; creating tries of 10000 members, and checking none of them get lost - done in an effort to ensure that it.. ya know. Works. ;) (especially given that you should have to have high numbers of insertions to get a Hashmap node)

hughfdjackson avatar Mar 29 '13 13:03 hughfdjackson

This, btw, is why I'm somewhat skeptical that testling can keep up: Screen Shot 2013-03-29 at 14 09 38

hughfdjackson avatar Mar 29 '13 14:03 hughfdjackson

If I remove the intensive tests: Screen Shot 2013-03-29 at 14 26 20

hughfdjackson avatar Mar 29 '13 14:03 hughfdjackson

@hughfdjackson testling ci is rather unreliable :D

Raynos avatar Mar 29 '13 17:03 Raynos