OutlookRulesReader icon indicating copy to clipboard operation
OutlookRulesReader copied to clipboard

Refactor reading of PeopleOrPublicGroupListRuleElementData

Open hughbe opened this issue 4 years ago • 0 comments

Thanks to some external help, there can be some improvements here

PeopleOrPublicGroupListRuleElementData

  • Rename to AddressListRuleElementData or something equivalent
  • May actually be reading an ADRLIST here. Read the numberOfValues and values as a ADRLIST structure.

PropertiesList

  • May actually be reading ADRENTRY here. Read unknown as ulReserved1 etc.
  • Need to confirm what the propertyBlockDataSize field is - this doesn't appear in the ADRENTRY docs...
  • Need to validate the reading of PT_BINARY properties. Currently we use data2 as the offset and data3 as the count of bytes, but this is reversed in the SBinary documentation

PropertyValueHeader

  • May actually be reading SPropValue here. Read data1 as dwAlignPad and data2/data3 as _PV. Need to confirm how offsets are encoded as the SPropValue docs specify that multi-byte fields within _PV are pointers, but it seems that they are offsets into the file... Confusing!

/cc @dmitry007

hughbe avatar Apr 28 '21 09:04 hughbe