transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Adding quotes to large command base inputs

Open dggaytan opened this issue 7 months ago • 4 comments

What does this PR do?

Before submitting

  • [✅] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [✅] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

cc: @ArthurZucker

dggaytan avatar Jun 09 '25 20:06 dggaytan

Hi @dggaytan, what's the reason for this change?

Rocketknight1 avatar Jun 10 '25 11:06 Rocketknight1

Hi @dggaytan, what's the reason for this change?

Improve usability, I was testing this example for XPU and since the example itself is kind of heavy, this simple change can avoid interruptions while running as the readme says.

dggaytan avatar Jun 10 '25 15:06 dggaytan

I'm not sure I understand! It seems like the usability is identical to me

Rocketknight1 avatar Jun 11 '25 12:06 Rocketknight1

Yes, so when I was copying and pasting the commands as it is in the readme, the large run command was not working as it should, and found out that when I added the quotes for the input values it worked fine

dggaytan avatar Jun 13 '25 17:06 dggaytan

Interesting - are you running on Windows?

Rocketknight1 avatar Jun 16 '25 14:06 Rocketknight1

on linux, ubuntu 22.04

dggaytan avatar Jun 16 '25 17:06 dggaytan

Hmm! I would have expected both commands to work the same, at least in common Linux shells. cc @sunmarc does accelerate expect input args to be quoted?

Rocketknight1 avatar Jun 17 '25 12:06 Rocketknight1

Hmm! I would have expected both commands to work the same, at least in common Linux shells. cc @SunMarc does accelerate expect input args to be quoted?

Hi there, realized there was an extra space at the beginning of the command so the rest of passing inputs wasn't being read correctly, quotes actually does not affect at all in numerical values

dggaytan avatar Jun 18 '25 18:06 dggaytan

That makes sense! Can we close the PR, in that case?

Rocketknight1 avatar Jun 19 '25 11:06 Rocketknight1

That makes sense! Can we close the PR, in that case?

The extra space appears in the readme from the main branch, I'm not sure how you handle this type of details (typos). 🤔

dggaytan avatar Jun 19 '25 19:06 dggaytan

Oh, I understand now! There's a space after the \ on the first line, which means that we don't escape the newline correctly. That makes sense! Can you rework this PR so that you leave everything else the same, but just delete that extra space? That should resolve the issue I think.

Rocketknight1 avatar Jun 20 '25 14:06 Rocketknight1

Oh, I understand now! There's a space after the \ on the first line, which means that we don't escape the newline correctly. That makes sense! Can you rework this PR so that you leave everything else the same, but just delete that extra space? That should resolve the issue I think.

Hi there, sorry for the late review, I think is all set now :) Let me know if there are some other changes needed

thanks

dggaytan avatar Jun 23 '25 19:06 dggaytan

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.